Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure no duplicate package names are stored in pyproject.toml #6832

Merged
merged 1 commit into from
Nov 3, 2022

Conversation

finswimmer
Copy link
Member

@finswimmer finswimmer commented Oct 18, 2022

When upgrading dependencies via poetry add <package>@latest it may result in multiple entries in pyproject.toml if the name returned by the API differs from the name given in the pyproject.toml, e.g. different upper/lower cases.

This PR fixes this by keeping the name given in the pyproject.toml and updating the version constraint.

Resolves: #6831

  • Added tests for changed code.
  • Updated documentation for changed code.

@finswimmer finswimmer marked this pull request as ready for review October 19, 2022 05:37
@finswimmer finswimmer requested review from a team and dimbleby October 19, 2022 05:38
dimbleby
dimbleby previously approved these changes Oct 19, 2022
Secrus
Secrus previously approved these changes Oct 27, 2022
@finswimmer finswimmer dismissed stale reviews from Secrus and dimbleby via 042be4c October 30, 2022 17:37
@neersighted neersighted added area/cli Related to the command line area/error-handling Bad error messages/insufficient error handling area/pyproject Metadata/pyproject.toml-related impact/changelog Requires a changelog entry labels Nov 3, 2022
@neersighted neersighted added this to the 1.3 milestone Nov 3, 2022
@neersighted neersighted merged commit 689b9af into python-poetry:master Nov 3, 2022
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/cli Related to the command line area/error-handling Bad error messages/insufficient error handling area/pyproject Metadata/pyproject.toml-related impact/changelog Requires a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Poetry adds conflicting requirements when cases are mixed
4 participants